-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: maximized button color issue #1607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! It looks good and it does work, however I'd recommend a slightly different approach so we don't need a new ButtonStyle
. See my comments for recommended changes. Thanks for your contribution!
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end.
* fix: maximized button color issue * Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift Co-authored-by: Austin Condiff <austin.condiff@gmail.com> * Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift Co-authored-by: Austin Condiff <austin.condiff@gmail.com> * Update CodeEdit/Features/UtilityArea/Views/UtilityAreaView.swift Co-authored-by: Austin Condiff <austin.condiff@gmail.com> * fix: remove unused code * fix: remove duplicate modifiers in icon style --------- Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Description
Related Issues
Checklist
Screenshots
before:
after:
dark theme
light theme